Security Group: add secondary ips to the correct ipset based on ip family#2988
Security Group: add secondary ips to the correct ipset based on ip family#2988RPDiep wants to merge 3 commits intoapache:masterfrom
Conversation
|
@GabrielBrascher Can you run tests? |
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2398 |
DaanHoogland
left a comment
DaanHoogland
left a comment
There was a problem hiding this comment.
looks good, but needs testing in all sorts of environments (with security groups only?)
|
Tested it on a hypervisor. The secondary ipv6 addresses were added to the ipv6 ipset before it was created. |
|
@RPDiep you can send bugfix PRs to 4.11 branch, you may edit the base branch of this PR to 4.11 and rebase your branch against 4.11. |
|
@rhtyd Already had a 4.11 branch prepared. New PR for 4.11: #2990 |
RPDiep
force-pushed
the
secondary_ipv6_master
branch
from
2a9303a to
9e3a1cb
Compare
|
closing this in favour of the 4.11 fix |
5 participants
Description
Currently secondary ipv6 addresses are added to the ipv4 ipset in
security_group.py.This doesn't work, so this patch adds a function to split a set of ips in ipv4 and ipv6 addresses.
Both the
default_network_rulesand `` functions now utilise this function and add the ips to the appropriate ipsets.Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
Not tested live yet. The function has been tested in idle.
Will ask my colleague @GabrielBrascher to test this.